backends/winrt: add address acquisition process when advertising data is None #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is None In some situations, device.details has the scan response data only and advertising data is None. Since the ble address cannot be obtained from device.details.adv this time, the ble address is obtained from the device.details.scan (scan response data).
|
Thanks for the PR! Can you please add a changelog entry? Also, I'm wondering if we could write this in a way that is a bit less verbose. Maybe something like this? data = address_or_ble_device.details
self._device_info = (data.adv or data.scan).bluetooth_addressAnd it would be good to fix the type hint at bleak/bleak/backends/winrt/scanner.py Line 53 in 181467f Optional[BluetoothLEAdvertisementReceivedEventArgs].)
|
CHANGELOG: Added about changing this PR
|
Thanks for the suggestion for a more concise description! I modify the type hints and update the changelog. |
|
Thanks for updating! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations, device.details has the scan response data only and advertising data is None.
Since the ble address cannot be obtained from device.details.adv this time, the ble address is obtained from the device.details.scan (scan response data).