fix BlueZ wait condition disconnect race #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlech
commented
Aug 25, 2023
dlech
force-pushed
the
bluez-wait-condition-disconnect-race
branch
from
87460b9
to
147b4e3
Compare
|
Updated:
|
|
@bdraco let me know if you want to test before merging |
|
Will give it a shot shortly |
dlech
commented
Aug 25, 2023
This makes sure all methods of the BlueZManager are checking that the adapter or device exists in BlueZ before continuing with the method. Documentation is updated to indicate which functions have this check and which do not.
…es_discovery() This adds a 3rd race condition to _wait_for_services_discovery() to handle the case where an interface is removed from BlueZ without changing the "Connected" property. This can happen, e.g. when we hit "retry due to le-connection-abort-by-local".
This adds a device path key to the condition callbacks. This will avoid calling callbacks for other devices that are not the subject of the current "PropertiesChanged" signal.
dlech
force-pushed
the
bluez-wait-condition-disconnect-race
branch
from
147b4e3
to
edfbd93
Compare
bdraco
approved these changes
Aug 25, 2023
|
Ran overnight frequent polling. Didn't notice the safety timeout ever kicking in anymore. Could be just luck but I think its solved |
|
Running for almost 48 hours now and no more safety timeouts. I think this is solved 👍 |
|
Thanks @dlech |
|
Thanks for testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #1329 and #1377.
@bdraco could you please take a look?
The issue addressed by #1377 seems more widespread, so I took it a bit farther to make sure it is fixed in all public functions (first commit).
Instead of synthesizing a
"Connected"property change as proposed in #1329, here I have opted to just add a 3rd race condition on"InterfacesRemoved"when waiting for services to be resolved (second commit).