Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows scanner crash #1331

Merged
merged 4 commits into from
Jul 18, 2023
Merged

Fix windows scanner crash #1331

merged 4 commits into from
Jul 18, 2023

Conversation

vmacari
Copy link
Contributor

@vmacari vmacari commented Jun 9, 2023

@vmacari vmacari mentioned this pull request Jun 9, 2023
Closed
@dlech
Copy link
Collaborator

dlech commented Jun 10, 2023

Can you also add a changelog entry?

@vmacari @dlech
Update bleak/backends/winrt/scanner.py
7446013 
Co-authored-by: David Lechner <david@lechnology.com>
vmacari
vmacari commented Jun 11, 2023
View reviewed changes
Copy link
Contributor Author

@vmacari vmacari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thank you!

@dlech dlech merged commit 8edde25 into hbldh:develop Jul 18, 2023
16 checks passed
@dlech dlech linked an issue Jul 18, 2023 that may be closed by this pull request
Scanner periodically crashes on Windows #1330
Closed
@dlech dlech mentioned this pull request Jul 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlech dlech dlech left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scanner periodically crashes on Windows
2 participants
@vmacari @dlech