Added support for 32bit UUID's added in 4.1 of the Bluetooth spec #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlech
reviewed
May 17, 2023
bleak/uuids.py
Outdated
| @@ -1157,11 +1157,16 @@ def normalize_uuid_str(uuid: str) -> str: | |||
| - Converted to lower case. | |||
| - 16-bit UUIDs are expanded to 128-bit. | |||
|
|
|||
| BLUETOOTH CORE SPECIFICATION Version 5.4 | Vol 3, Part B - Section 2.5.1 | |||
There was a problem hiding this comment.
I'm not sure we need this in the documentation. I don't expect anyone to actually look it up.
There was a problem hiding this comment.
I still think the Bluetooth spec reference would be better as a code comment rather than a documentation comment.
Co-authored-by: David Lechner <david@lechnology.com>
Co-authored-by: David Lechner <david@lechnology.com>
|
Morning. Any chance of progressing the pull request? Please let me know if there is anything else I need to do. |
dlech
reviewed
Jun 13, 2023
bleak/uuids.py
Outdated
| @@ -1157,11 +1157,16 @@ def normalize_uuid_str(uuid: str) -> str: | |||
| - Converted to lower case. | |||
| - 16-bit UUIDs are expanded to 128-bit. | |||
|
|
|||
| BLUETOOTH CORE SPECIFICATION Version 5.4 | Vol 3, Part B - Section 2.5.1 | |||
There was a problem hiding this comment.
I still think the Bluetooth spec reference would be better as a code comment rather than a documentation comment.
|
I have added a change log and fixed the doc format. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Guidelines for Bleak
Before you submit a pull request, check that it meets these guidelines:
CHANGELOG.rst, describing your changes as is specified by theguidelines in that document.
different problems and you are committing them in the same PR. In that case,
consider making several PRs instead.
AUTHORS.rstfile!