Greek Language Added to hbb20 Country Picker Project #259
Conversation
|
Happy codind and my new very first pull request |
|
@khanboy1989 , Congratulations on your very first PR. Code changes looks good. I will merge after a test by running code. Just want to know if the translations are done manually and can be considered as authenticate or they are from some translation service (like google translator) and might need correction in future? |
|
To be honest, greek.xml is completed by me. Some of the countries I did not know so I checked them on google but I tried to avoid using Google Translate. However, I have used google translate in some countries i can say a few times not a lot |
|
Hi Harsh,
To be honest, greek.xml is completed by me. Some of the countries I did not
know so I checked them on google but I tried to avoid using Google
Translate. However, I have used google translate in some countries i can
say a few times not a lot
Regards
Serhan Khan
…On Mon, 12 Nov 2018 at 19:03, Harsh B. Bhakta ***@***.***> wrote:
@khanboy1989 <https://github.com/khanboy1989> , Congratulations on your
very first PR. Code changes looks good. I will merge after a test by
running code.
Just want to know if the translations are done manually and can be
considered as authenticate or they are from some translation service (like
google translator) and might need correction in future?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#259 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKn01s7vQWO6uiked5lOjDjSXmCvmW9Jks5uuan1gaJpZM4YZZqj>
.
|
|
Hello am also interested in using greek so is there any updates on when the merge will take place? |
|
any updates? |
|
Waiting for Harsh to merge my pull request. He did not reply back or merge my changes |
|
Sorry everyone. I was all set to release but something was broken in my
tool so could not upload. Then got stuck with finals and projects. I'll try
to fix it as soon as possible. Sorry for the long delay.
…On Wed, Dec 12, 2018 at 09:37 khanboy1989 ***@***.***> wrote:
Waiting for Harsh to merge my pull request. He did not reply back or merge
my changes
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#259 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEsN6Di2UYHWWRqtGjf-k6-DictXS-JQks5u4SLRgaJpZM4YZZqj>
.
|
|
Until we release official v2.2.4, please check v2.2.3.1. It has greek language support. If you face any problem, please let us know... |
|
Thanks for the merge |
|
Thanks a lot |
3 participants
No description provided.