Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the zfar and znear arguments to GaussianRasterizationSettings #95

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Tordjx
Copy link

@Tordjx Tordjx commented Jun 25, 2024

Hi there !

This is the companion PR of the one I did in the 'diff-surfel-rasterization' repository, that you can find here.

This PR enables to actually take into account the znear and zfar camera parameters in the rasterizer, and hence to render some cool distance cropped image as you may find below.
1(2)
3

@hbb1
Copy link
Owner

hbb1 commented Jun 28, 2024

Thank you, I would like keep the same interface as 3DGS for facilitating research. But it deed really helpful, I will consider to integrate it for a viewer in the future.

@chenqi13814529300
Copy link

Hi there !

This is the companion PR of the one I did in the 'diff-surfel-rasterization' repository, that you can find here.

This PR enables to actually take into account the znear and zfar camera parameters in the rasterizer, and hence to render some cool distance cropped image as you may find below. 1(2) 3

Does your zfar and znear work in rasterization? Aren't they already initialized by default in class Camera (nn. Module)?
image

@Tordjx
Copy link
Author

Tordjx commented Jul 19, 2024

Hi, even though the arguments znear and zfar are in the class Camera, they are not passed to the rasterizer. Instead, they are defined as a constant in a header. This implies that they don't have an effect on the frustum culling viewing condition.

@hbb1
Copy link
Owner

hbb1 commented Dec 30, 2024

Hi, even though the arguments znear and zfar are in the class Camera, they are not passed to the rasterizer. Instead, they are defined as a constant in a header. This implies that they don't have an effect on the frustum culling viewing condition.

Exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants