Skip to content

Commit

Permalink
fix support level for HTTPRequestHeaderFilter
Browse files Browse the repository at this point in the history
As noted in kubernetes-sigs#655, a core filter with extended support fields is
confusing and also seems to be incorrect.
This patch drops the extended field from the filter and is a partial fix
for the referenced issue.

HTTPRequestMirroFilter has not been patch as GEP-718 could potentially
simplify that.
  • Loading branch information
hbagdi committed Jul 13, 2021
1 parent b821539 commit 89bc60a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 13 deletions.
6 changes: 0 additions & 6 deletions apis/v1alpha2/httproute_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -606,8 +606,6 @@ type HTTPRequestHeaderFilter struct {
// GET /foo HTTP/1.1
// my-header: bar
//
// Support: Extended
//
// +optional
Set []HTTPHeader `json:"set,omitempty"`

Expand All @@ -627,8 +625,6 @@ type HTTPRequestHeaderFilter struct {
// my-header: foo
// my-header: bar
//
// Support: Extended
//
// +optional
Add []HTTPHeader `json:"add,omitempty"`

Expand All @@ -650,8 +646,6 @@ type HTTPRequestHeaderFilter struct {
// GET /foo HTTP/1.1
// my-header2: bar
//
// Support: Extended
//
// +optional
// +kubebuilder:validation:MaxItems=16
Remove []string `json:"remove,omitempty"`
Expand Down
13 changes: 6 additions & 7 deletions config/crd/bases/gateway.networking.k8s.io_httproutes.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 89bc60a

Please sign in to comment.