Feature/react select autocomplete off #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvorcak
requested review from
aigoncharov,
danad02,
jankoritak and
jozefhruska
as code owners
jvorcak
changed the title
jvorcak
force-pushed
the
feature/react-select-autocomplete-off
branch
from
78a610b
to
5bb4d1b
Compare
jvorcak
changed the title
aigoncharov
reviewed
Dec 28, 2020
packages/ui/src/SelectField.tsx
Outdated
| const Input = (props: any) => { | ||
| // autoComplete='off' is hard-coded inside SelectField, but doesn't work in Chrome. | ||
| // Having an invalid value hard-coded disabled it in all browsers. | ||
| return <components.Input {...props} autoComplete="one-time-code" /> |
There was a problem hiding this comment.
@aigoncharov I couldn't decide whether it's better to use an invalid a11y value or a value that shouldn't in practice effect functionality. I was 50/50, now I'm thinking an explicit chrome-off could be better, even though it's invalid.
aigoncharov
approved these changes
Dec 28, 2020
danad02
approved these changes
Dec 29, 2020
|
If it's ok with you I'll merge and fix #145 afterward, I'm quite limited on time right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I admit this is not very elegant, but it works. Instead of using currently hard-coded value off, we hard-code it to chrome-off which really disables it in all browsers.
Any other suggestions are welcome.
Do you have any other use-cases where we would actually need to provide a value for this component?
Problem with a current implementation:
Related issue: JedWatson/react-select#3500