Skip to content

Conversation

yuce
Copy link
Contributor

@yuce yuce commented Sep 19, 2025

This is the initial asyncio support.

  • Added the asyncio module which contains public asyncio API
  • Added the internal module and internal/asyncio_ modules, which contains the private asyncio API/implementation.
  • Added asyncio support for the Map proxy. Currently near cache, transactions, and lock releated-methods are not supported. The near cache support will come in another PR. Transactions will likely not be supported. Locks may need a different design.
  • I didn't include the API docs, in order to make the PR smaller. I'll add them in another PR.
  • The following tests are ported from the old API, and they work without changes (besides making them compatible with async/await syntax):
    • tests/integration/asyncio/authentication_tests
    • tests/integration/asyncio/backup_acks_tests
    • tests/integration/asyncio/client_test (one test is not ported, due to its Topic DDS dependency)
    • tests/integration/asyncio/proxy/map_test

All Python 3.13 tests pass, but since the minimum required Python is 3.11, 3.8 tests fail.
We'll replace 3.8 with 3.11 in another PR.

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 76.15921% with 581 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.44%. Comparing base (aae561c) to head (170cf89).

Files with missing lines Patch % Lines
hazelcast/internal/asyncio_connection.py 75.88% 150 Missing ⚠️
hazelcast/internal/asyncio_proxy/map.py 78.26% 125 Missing ⚠️
hazelcast/internal/asyncio_invocation.py 72.41% 80 Missing ⚠️
hazelcast/internal/asyncio_cluster.py 63.88% 65 Missing ⚠️
hazelcast/internal/asyncio_compact.py 32.89% 51 Missing ⚠️
hazelcast/internal/asyncio_listener.py 79.23% 38 Missing ⚠️
hazelcast/asyncio/client.py 84.36% 33 Missing ⚠️
hazelcast/internal/asyncio_proxy/base.py 77.53% 31 Missing ⚠️
hazelcast/internal/asyncio_proxy/manager.py 90.00% 4 Missing ⚠️
hazelcast/internal/asyncio_reactor.py 96.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #741      +/-   ##
==========================================
- Coverage   95.32%   93.44%   -1.88%     
==========================================
  Files         378      389      +11     
  Lines       21989    24426    +2437     
==========================================
+ Hits        20960    22824    +1864     
- Misses       1029     1602     +573     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants