Skip to content

[API-2187] Fixes API-2187 #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2024
Merged

[API-2187] Fixes API-2187 #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e2a26a
Fixes API-2100
yuce Aug 6, 2024
dbb0ed0
Merge branch 'master' into fix/ap2100-paging-predicate
yuce Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hazelcast/protocol/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def of(predicate, to_data):
anchor_data_list.append((key, value))

anchor_data_list_holder = AnchorDataListHolder(page_list, anchor_data_list)
predicate_data = to_data(predicate)
predicate_data = to_data(predicate._internal_predicate)
comparator_data = to_data(predicate.comparator)
iteration_type = predicate.iteration_type

Expand Down
2 changes: 1 addition & 1 deletion start_rc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import sys
from os.path import isfile

SERVER_VERSION = "5.5.0-SNAPSHOT"
SERVER_VERSION = "5.5.0"
RC_VERSION = "0.8-SNAPSHOT"

RELEASE_REPO = "https://repo1.maven.apache.org/maven2"
Expand Down
6 changes: 1 addition & 5 deletions tests/integration/backward_compatible/predicate_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
write_string_to_writer,
read_string_from_reader,
)
from tests.util import random_string, get_abs_path, skip_if_server_version_newer_than_or_equal
from tests.util import random_string, get_abs_path
from hazelcast import HazelcastClient


Expand Down Expand Up @@ -171,8 +171,6 @@ def test_false(self):
self.assertCountEqual(self.map.key_set(predicate), [])

def test_paging(self):
# https://github.com/hazelcast/hazelcast-python-client/issues/666
skip_if_server_version_newer_than_or_equal(self, self.client, "5.4")
self.fill_map_numeric()
predicate = paging(less("this", 4), 2)
self.assertCountEqual([0, 1], self.map.key_set(predicate))
Expand Down Expand Up @@ -341,8 +339,6 @@ def setUpClass(cls):
cls.map = cls.client.get_map(random_string()).blocking()

def setUp(self):
# https://github.com/hazelcast/hazelcast-python-client/issues/666
skip_if_server_version_newer_than_or_equal(self, self.client, "5.4")
self.map.clear()

@classmethod
Expand Down