Eagerly deserialize SQL columns of type OBJECT [API-1964] #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to lazy deserialization, Compact serialized objects were not working nicely with SQL. It was possible to get deserialization errors that cannot be easily understood by the user. Similar to what we did for other APIs, we have removed lazy deserialization from this API as well. To do that efficiently, I have modified the protocol code generator so that we can pass to_object function to the SqlPageCodec where we can do deserialization while filling rows and columns, so that we will not iterate over the result set once more.
mdumandag
force-pushed
the
sql-eager-deserialization
branch
from
31f313a to
47df7c3
Compare
Codecov Report
@@ Coverage Diff @@
## master #619 +/- ##
==========================================
+ Coverage 96.47% 96.50% +0.03%
==========================================
Files 357 357
Lines 20529 20632 +103
==========================================
+ Hits 19805 19911 +106
+ Misses 724 721 -3
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yuce
reviewed
Mar 24, 2023
Contributor
yuce
left a comment
yuce
left a comment
There was a problem hiding this comment.
Looks good, two minor comments.
yuce
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to lazy deserialization, Compact serialized objects were
not working nicely with SQL. It was possible to get deserialization
errors that cannot be easily understood by the user.
Similar to what we did for other APIs, we have removed lazy
deserialization from this API as well.
To do that efficiently, I have modified the protocol code generator
so that we can pass to_object function to the SqlPageCodec where
we can do deserialization while filling rows and columns, so that
we will not iterate over the result set once more.
protocol pr: hazelcast/hazelcast-client-protocol#461