Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion hazelcast/serialization/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,8 @@ def lookup_custom_serializer(self, obj_type):
serializer = self._type_dict.get(obj_type, None)
if serializer is not None:
return serializer
for super_type in obj_type.__subclasses__():

for super_type in obj_type.__mro__:
serializer = self.register_from_super_type(obj_type, super_type)
if serializer is not None:
return serializer
Expand Down
26 changes: 26 additions & 0 deletions tests/unit/serialization/custom_global_serialization_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ def __eq__(self, other):
return False


class ChildCustomClass(CustomClass):
pass


class CustomSerializer(StreamSerializer):
def write(self, out, obj):
if isinstance(obj, CustomClass):
Expand Down Expand Up @@ -128,3 +132,25 @@ def test_double_register_custom_serializer(self):

with self.assertRaises(ValueError):
service._registry.safe_register_serializer(TheOtherCustomSerializer, CustomClass)

def test_serializing_class_instances(self):
config = Config()
config.custom_serializers = {CustomClass: CustomSerializer}
service = SerializationServiceV1(config)

for clazz in (CustomClass, ChildCustomClass):
data = service.to_data(clazz)
deserialized = service.to_object(data)
self.assertEqual(clazz, deserialized)

def test_serializing_child_class_instances_with_super_class_serializer(self):
config = Config()
config.custom_serializers = {CustomClass: CustomSerializer}
service = SerializationServiceV1(config)

obj = ChildCustomClass("uid", "some name", "description text", "CUSTOM")
data = service.to_data(obj)
deserialized = service.to_object(data)

self.assertIsInstance(deserialized, CustomClass)
self.assertEqual(obj, deserialized)