Remove duplicate type hints #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdumandag
force-pushed
the
unnecessary-type-annotations
branch
from
17a4a7e to
449ff78
Compare
Formerly, we had type hints in the docstrings, but after introducing the actual type hints, they are not needed anymore. This PR removes those duplicate type hints in the docstrings from the public APIs.
mdumandag
force-pushed
the
unnecessary-type-annotations
branch
from
449ff78 to
cf71f4e
Compare
Codecov Report
@@ Coverage Diff @@
## master #534 +/- ##
==========================================
- Coverage 95.93% 95.64% -0.30%
==========================================
Files 346 346
Lines 18009 18007 -2
==========================================
- Hits 17277 17222 -55
- Misses 732 785 +53
Continue to review full report at Codecov.
|
yuce
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formerly, we had type hints in the docstrings, but after
introducing the actual type hints, they are not needed anymore.
This PR removes those duplicate type hints in the docstrings from
the public APIs.