Skip to content

Conversation

mdumandag
Copy link
Contributor

While sending a PR to the 4.2.z branch, I saw that it uses the GA
workflows defined in that branch, so I am updating the test runner
and jira trigger workflows so that, the test runner creates
jobs that would pass the merge checks.

The only difference between this test runner and the one in the
master is that, this one does not check broken links in the readme.

While sending a PR to the 4.2.z branch, I saw that it uses the GA
workflows defined in that branch, so I am updating the test runner
and jira trigger workflows so that, the test runner creates
jobs that would pass the merge checks.

The only difference between this test runner and the one in the
master is that, this one does not check broken links in the readme.
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2021

Codecov Report

Merging #495 (5862946) into 4.2.z (da647b8) will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.2.z     #495      +/-   ##
==========================================
+ Coverage   94.51%   94.83%   +0.32%     
==========================================
  Files         345      345              
  Lines       17547    17554       +7     
==========================================
+ Hits        16584    16647      +63     
+ Misses        963      907      -56     
Impacted Files Coverage Δ
...otocol/codec/client_authentication_custom_codec.py 50.00% <0.00%> (-23.81%) ⬇️
hazelcast/reactor.py 81.06% <0.00%> (-6.04%) ⬇️
hazelcast/connection.py 91.09% <0.00%> (-1.42%) ⬇️
hazelcast/proxy/base.py 97.40% <0.00%> (-0.65%) ⬇️
hazelcast/invocation.py 93.48% <0.00%> (ø)
hazelcast/proxy/flake_id_generator.py 95.28% <0.00%> (+0.13%) ⬆️
hazelcast/sql.py 97.86% <0.00%> (+0.42%) ⬆️
hazelcast/metrics.py 99.50% <0.00%> (+0.49%) ⬆️
hazelcast/protocol/client_message.py 95.29% <0.00%> (+1.76%) ⬆️
hazelcast/listener.py 94.23% <0.00%> (+1.92%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da647b8...5862946. Read the comment docs.

Copy link
Contributor

@srknzl srknzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but won't we need to update docs and check links in them? we may do so in a patch release.

@srknzl
Copy link
Contributor

srknzl commented Oct 6, 2021

note that documentation generation checks for all dead links, not just in README (as far as I know)

@mdumandag
Copy link
Contributor Author

mdumandag commented Oct 6, 2021

@srknzl I will do that in a later PR, I just wanted to merge the prerequisite for all others

@mdumandag mdumandag merged commit 0bc4796 into hazelcast:4.2.z Oct 6, 2021
@mdumandag mdumandag deleted the 4.2.z-ga branch October 6, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants