[API-901] Get rid of the execute_statement API for SQL
#484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdumandag
changed the title
execute_statement API for SQLexecute_statement API for SQL
We were providing two APIs two execute SQL queries. - `execute` with a string query and parameters - `execute_statement` with `SqlStatement` parameter two have more control over the query execution. We decided to get rid of the `execute_statement` and `SqlStatement` and provide ability to pass keyword arguments to `execute` to customize the behavior of the queries. With that change, the properties of `SqlStatement` is now keyword arguments. Also, upgraded the server version to 5.0 as 5.0 is released.
mdumandag
force-pushed
the
execute-kwargs
branch
from
4801c0e to
744e4ee
Compare
mdumandag
commented
Sep 23, 2021
| Returns: | ||
| hazelcast.future.Future[SqlResult]: The execution result. | ||
| """ | ||
| statement = _SqlStatement(sql, params, **kwargs) |
Contributor
Author
There was a problem hiding this comment.
For the reviewers, I construct the statement outside of the try-except block below so that, for validation errors, we immediately throw the exception not ImmediateFutureException
yuce
approved these changes
Sep 24, 2021
Contributor
yuce
left a comment
yuce
left a comment
There was a problem hiding this comment.
Thanks, the PR looks great. Just One typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were providing two APIs two execute SQL queries.
executewith a string query and parametersexecute_statementwithSqlStatementparameter two have morecontrol over the query execution.
We decided to get rid of the
execute_statementandSqlStatementand provide ability to pass keyword arguments to
executeto customizethe behavior of the queries. With that change, the properties of
SqlStatementis now keyword arguments.Also, upgraded the server version to 5.0 as 5.0 is released.