Skip to content

Conversation

RobHam99
Copy link
Contributor

@RobHam99 RobHam99 commented Aug 18, 2021

project method added to map.py, projection.py added including IdentityProjection, SingleAttributeProjection and MultiAttributeProjection.

Closes #203

@devOpsHazelcast
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@devOpsHazelcast
Copy link
Contributor

Can one of the admins verify this patch?

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2021

Codecov Report

Merging #451 (265aad1) into master (4753b54) will increase coverage by 8.14%.
The diff coverage is 92.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
+ Coverage   86.06%   94.20%   +8.14%     
==========================================
  Files         340      345       +5     
  Lines       17938    17545     -393     
==========================================
+ Hits        15438    16529    +1091     
+ Misses       2500     1016    -1484     
Impacted Files Coverage Δ
hazelcast/core.py 94.48% <75.00%> (+2.70%) ⬆️
hazelcast/projection.py 87.50% <87.50%> (ø)
hazelcast/proxy/map.py 88.83% <93.33%> (+15.45%) ⬆️
hazelcast/protocol/codec/map_project_codec.py 100.00% <100.00%> (ø)
...protocol/codec/map_project_with_predicate_codec.py 100.00% <100.00%> (ø)
hazelcast/serialization/serialization_const.py 100.00% <100.00%> (ø)
hazelcast/serialization/serializer.py 96.01% <100.00%> (+6.33%) ⬆️
hazelcast/serialization/service.py 96.73% <100.00%> (+36.91%) ⬆️
hazelcast/reactor.py 79.56% <0.00%> (-4.65%) ⬇️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4753b54...265aad1. Read the comment docs.

Copy link
Contributor

@mdumandag mdumandag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty code, left some more minor comments

@mdumandag
Copy link
Contributor

verify

@mdumandag
Copy link
Contributor

@RobHam99 a test failed in Python 2. To fix this, we need to define __hash__ for HazelcastJsonValue.

Please add the following methods to hazelcast/core.py/HazelcastJsonValue class

    def __hash__(self):
        return hash(self._json_string)

    def __repr__(self):
        return self._json_string

@mdumandag
Copy link
Contributor

verify

Copy link
Contributor

@mdumandag mdumandag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution Rob, I am merging this

@mdumandag mdumandag merged commit f05112e into hazelcast:master Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Projections
4 participants