Skip to content

Conversation

yuce
Copy link
Contributor

@yuce yuce commented Aug 9, 2021

  • Enables credentials and custom authentication.
  • Adds creds_username, creds_password and token_provider configuration.
  • Adds TokenProvider class, which is the base class for custom authentication classes.
  • Adds BasicTokenProvider class for token-based authentication.
  • Authentication docs, sample code and tests.

@yuce yuce changed the title [WIP] Adds credentials and custom authentication support Adds credentials and custom authentication support Aug 16, 2021
@yuce yuce requested a review from mdumandag August 16, 2021 13:56
@yuce
Copy link
Contributor Author

yuce commented Aug 16, 2021

@mdumandag This one should be good to review.

@mdumandag
Copy link
Contributor

I am OK with the code now. I will approve once the tests on Jenkins pass

@codecov-commenter
Copy link

Codecov Report

Merging #446 (b43455a) into master (4753b54) will increase coverage by 8.12%.
The diff coverage is 73.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #446      +/-   ##
==========================================
+ Coverage   86.06%   94.19%   +8.12%     
==========================================
  Files         340      343       +3     
  Lines       17938    17440     -498     
==========================================
+ Hits        15438    16427     +989     
+ Misses       2500     1013    -1487     
Impacted Files Coverage Δ
hazelcast/client.py 99.54% <ø> (+23.02%) ⬆️
...otocol/codec/client_authentication_custom_codec.py 50.00% <50.00%> (ø)
hazelcast/connection.py 91.02% <60.00%> (+8.29%) ⬆️
hazelcast/security/token_provider.py 92.30% <92.30%> (ø)
hazelcast/config.py 99.37% <100.00%> (+5.54%) ⬆️
hazelcast/security/__init__.py 100.00% <100.00%> (ø)
hazelcast/reactor.py 79.56% <0.00%> (-4.65%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4753b54...b43455a. Read the comment docs.

@yuce yuce merged commit a6da8ef into hazelcast:master Aug 18, 2021
@yuce yuce deleted the 665-custom-auth branch August 18, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants