Skip to content

Fix invocation retry logic #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdumandag merged 1 commit into from
Jun 15, 2021
Merged

Fix invocation retry logic #413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion hazelcast/invocation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,9 +270,14 @@ def _notify_error(self, invocation, error):
self._complete_with_error(invocation, error)
return

invoke_func = functools.partial(self._do_invoke, invocation)
invocation.sent_connection = None
invoke_func = functools.partial(self._retry_if_not_done, invocation)
self._reactor.add_timer(self._invocation_retry_pause, invoke_func)

def _retry_if_not_done(self, invocation):
if not invocation.future.done():
self._do_invoke(invocation)

def _should_retry(self, invocation, error):
if invocation.connection and isinstance(error, (IOError, TargetDisconnectedError)):
return False
Expand Down