Pretty print cluster connect timeout in logs #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, we were logging the cluster connect timeout as it is. Its default value is equal to `sys.maxsize`, so the logs were like ``` ... cluster connect timeout: 92233720368547758067s ... ``` We now output `INFINITE` for the default value. ``` ... cluster connect timeout: INFINITE ``` If the user provides a different value, it will be printed as it is now.
yuce
requested changes
May 10, 2021
mdumandag
force-pushed
the
timeout-logging
branch
from
8459edb to
44d5a7c
Compare
ihsandemir
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, we were logging the cluster connect timeout
as it is. Its default value is equal to
sys.maxsize, so thelogs were like
We now output
INFINITEfor the default value.If the user provides a different value, it will be printed
as it is now.
Closes #404