Fix tag_image_push_rhel.yml for push triggers [DI-375]
#846
+5
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #844, the `HZ_VERSION` is computed using the `required` `HZ_VERSION` `input`. However, this is only `required` for `workflow_dispatch` triggers - it can _also_ be triggered by `push`, where it's instead empty - causing an [action failure](https://github.com/hazelcast/hazelcast-docker/actions/runs/12521044660): ``` Run madhead/semver-utils@latest Error: Input required and not supplied: version ``` The workflow already derived an appropriate `HZ_VERSION` environment variable by validating the one in the in the `input` - updated to use this instead as it _should_ have done in the first place.
JackPGreen
changed the title
tag_image_push_rhel.yml for push triggerstag_image_push_rhel.yml for push triggers [DI-375]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #844, the
HZ_VERSIONis computed using therequiredHZ_VERSIONinput.However, this is only
requiredforworkflow_dispatchtriggers - it can also be triggered bypush, where it's instead empty - causing an action failure:The workflow already derived an appropriate
HZ_VERSIONenvironment variable by validating the one in the in theinput- updated to use this instead as it should have done in the first place.Also simplified the above logic to avoid it overwriting
env.HZ_VERSIONwith the same value pointlessly.Fixes: DI-375