Update logging configuration after changes in distribution #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set default value for LOGGING_LEVEL in log4j2 properties. In hazelcast/hazelcast#20528 we remove setting the default value in the scripts and moved it do the log4j2 config file. In Docker image we use specific config file without rolling file appender (only log to console). The changes in the main distribution need to be applied to this config files as well.
ldziedziul
approved these changes
Feb 14, 2022
SeriyBg
approved these changes
Feb 14, 2022
|
|
||
| rootLogger.level=${env:LOGGING_LEVEL} | ||
| rootLogger.level=${env:LOGGING_LEVEL:-INFO} |
There was a problem hiding this comment.
Is the - a typo, or is it a supported syntax?
There was a problem hiding this comment.
It is the syntax for the default value - see https://logging.apache.org/log4j/2.x/manual/lookups.html.
There was a problem hiding this comment.
Oh, I see. I thought the syntax was the same as for spring, that is ${LOGGING_LEVEL:INFO}.
ldziedziul
pushed a commit
to ldziedziul/hazelcast-docker
that referenced
this pull request
Jun 1, 2022
…#346) Set default value for LOGGING_LEVEL in log4j2 properties. In hazelcast/hazelcast#20528 we remove setting the default value in the scripts and moved it do the log4j2 config file. In Docker image we use specific config file without rolling file appender (only log to console). The changes in the main distribution need to be applied to this config files as well. * Document LOGGING_CONFIG in the Readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Docker image, we use a specific config file without the rolling file
appender (only log to console). The changes in the main distribution
need to be applied to these config files as well.
Set default value for LOGGING_LEVEL in log4j2 properties.
In hazelcast/hazelcast#20528 we removed setting
the default value in the scripts and moved it to the log4j2 config file.