Skip to content

Introduce hazelcast::client::decimal [API-1297] #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 26, 2022
Merged

Introduce hazelcast::client::decimal [API-1297] #967

merged 8 commits into from
Apr 26, 2022

Conversation

sancar
Copy link
Contributor

@sancar sancar commented Apr 19, 2022

This class will be used in SQL and in Compact to match with
Decimal type on SQL and Compact. a.k.a BigDecimal on java.

@sancar sancar added this to the 5.1.0 milestone Apr 19, 2022
@sancar sancar self-assigned this Apr 19, 2022
@devOpsHazelcast
Copy link
Contributor

Windows test FAILed.

@devOpsHazelcast
Copy link
Contributor

Linux test PASSed.

@devOpsHazelcast
Copy link
Contributor

Windows test PASSed.

@devOpsHazelcast
Copy link
Contributor

Linux test PASSed.

@srknzl
Copy link

srknzl commented Apr 19, 2022

Why about adding this to builtin serializers? Currently what do we have for bigdecimal in cpp? If we are going to do it, can you create an issue in Jira to track it?

srknzl
srknzl suggested changes Apr 20, 2022
View reviewed changes
Copy link

@srknzl srknzl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first part of the review just including the review of .h file

@sancar
Copy link
Contributor Author

sancar commented Apr 20, 2022

Why about adding this to builtin serializers? Currently what do we have for bigdecimal in cpp? If we are going to do it, can you create an issue in Jira to track it?

I think there is already jira tasks for all missing types in all the languages. See https://hazelcast.atlassian.net/jira/software/projects/API/boards/40/backlog?selectedIssue=API-884&text=serializers

@hazelcast hazelcast deleted a comment from devOpsHazelcast Apr 20, 2022
@hazelcast hazelcast deleted a comment from devOpsHazelcast Apr 20, 2022
@hazelcast hazelcast deleted a comment from devOpsHazelcast Apr 20, 2022
@hazelcast hazelcast deleted a comment from devOpsHazelcast Apr 20, 2022
@devOpsHazelcast
Copy link
Contributor

Windows test PASSed.

@devOpsHazelcast
Copy link
Contributor

Linux test PASSed.

srknzl
srknzl reviewed Apr 20, 2022
View reviewed changes
srknzl
srknzl previously approved these changes Apr 20, 2022
View reviewed changes
ihsandemir
ihsandemir reviewed Apr 21, 2022
View reviewed changes
hazelcast/src/hazelcast/client/decimal.cpp Outdated
for (auto& item : a) {
item = ~item;
}
int carry = 1;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you document what is the purpose of carry?

ihsandemir
ihsandemir reviewed Apr 21, 2022
View reviewed changes
@devOpsHazelcast
Copy link
Contributor

Windows test PASSed.

@devOpsHazelcast
Copy link
Contributor

Linux test PASSed.

@devOpsHazelcast
Copy link
Contributor

Windows test PASSed.

@devOpsHazelcast
Copy link
Contributor

Linux test PASSed.

srknzl
srknzl reviewed Apr 23, 2022
View reviewed changes
@devOpsHazelcast
Copy link
Contributor

Windows test PASSed.

@devOpsHazelcast
Copy link
Contributor

Linux test PASSed.

@ihsandemir ihsandemir changed the title Introduce hazelcast::client::decimal Introduce hazelcast::client::decimal[API-1297] Apr 25, 2022
@ihsandemir ihsandemir changed the title Introduce hazelcast::client::decimal[API-1297] Introduce hazelcast::client::decimal [API-1297] Apr 25, 2022
srknzl
srknzl previously approved these changes Apr 25, 2022
View reviewed changes
ihsandemir
ihsandemir previously approved these changes Apr 25, 2022
View reviewed changes
@sancar sancar dismissed stale reviews from ihsandemir and srknzl via 29d494f April 26, 2022 06:55
@hazelcast hazelcast deleted a comment from devOpsHazelcast Apr 26, 2022
@hazelcast hazelcast deleted a comment from devOpsHazelcast Apr 26, 2022
@hazelcast hazelcast deleted a comment from devOpsHazelcast Apr 26, 2022
@devOpsHazelcast
Copy link
Contributor

Linux test PASSed.

@ihsandemir
Copy link
Collaborator

Serkan, already approved the PR. Merging the PR.

@devOpsHazelcast
Copy link
Contributor

Windows test PASSed.

@ihsandemir ihsandemir merged commit ac039d1 into hazelcast:master Apr 26, 2022
@ihsandemir ihsandemir deleted the decimal branch April 26, 2022 08:19
sancar pushed a commit to sancar/hazelcast-cpp-client that referenced this pull request Apr 28, 2022
Introduce hazelcast::client::decimal [API-1297] (hazelcast#967)
c00cf92 
* Introduce hazelcast::client::decimal

This class will be used in SQL and in Compact to match with
Decimal type on SQL and Compact. a.k.a BigDecimal on java.

* add equality operator

* rename decimal to big_decimal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihsandemir ihsandemir ihsandemir approved these changes

+1 more reviewer

@srknzl srknzl srknzl left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@sancar sancar

Labels
Source: Internal Type: Enhancement
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sancar @devOpsHazelcast @srknzl @ihsandemir