Skip to content

Commit

Permalink
fix: Ensures build replaces the VERSION PLACEHOLDER
Browse files Browse the repository at this point in the history
  • Loading branch information
phantomjinx committed May 9, 2024
1 parent b6faa59 commit 5deeb9b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions packages/online-shell/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@
],
"scripts": {
"start": "webpack serve --hot --mode development --progress --config webpack.config.dev.js",
"build": "yarn build:webpack && yarn replace-version yarn",
"build": "yarn build:webpack && yarn replace-version",
"build:webpack": "webpack --mode production --progress --config webpack.config.prod.js --output-public-path='/online/'",
"replace-version": "replace __PACKAGE_VERSION_PLACEHOLDER__ $npm_package_version ./build -r",
"replace-version": "replace __HAWTIO_ONLINE_PACKAGE_VERSION_PLACEHOLDER__ $npm_package_version ./build -r",
"test": "jest --watchAll=false --passWithNoTests",
"test:coverage": "yarn test --coverage",
"analyze:webpack:dev": "webpack --mode development --analyze --progress --config webpack.config.dev.js --output-public-path='/online/'",
Expand Down
2 changes: 1 addition & 1 deletion packages/online-shell/src/bootstrap.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import ReactDOM from 'react-dom/client'
import { discover } from './discover'
import { reportWebVitals } from './reportWebVitals'

configManager.addProductInfo('Hawtio Online', '__PACKAGE_VERSION_PLACEHOLDER__')
configManager.addProductInfo('Hawtio Online', '__HAWTIO_ONLINE_PACKAGE_VERSION_PLACEHOLDER__')

const root = ReactDOM.createRoot(document.getElementById('root') as HTMLElement)
root.render(<HawtioLoadingPage />)
Expand Down

0 comments on commit 5deeb9b

Please sign in to comment.