refactor(Logic/Modal): register pass — refinement class is le, doc fixes - #1983
Merged
Conversation
hawkrobe
disabled auto-merge
August 12, 2026 00:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register and API pass on
Modal/Defs.lean, following an architecture check against mathlib, plus consumer-driven refinements.IsBeliefRefinementOfdeleted (it was the pointwiseRb ≤ Rk);IsSerial.serialis nowRelator.LeftTotal R(theIsWellFounded.wfpattern); three redundant⊤-instances deleted (derivable fromRefl+Euclideanvia the file's own implication chain); instance priorities dropped (Lean 4 tabled resolution handles the cyclic derivations; Prop-class selection is proof-irrelevant).□[R]/◇[R]notation (mathlib~[R]style, partially-applied so ordinary application gives□[R] p w); duality restated in push-negation normal form as@[simp] not_box/not_diamondwith one-line simp proofs, replacing the hand-rolled classical terms (sole consumer's textbookdualitynow derives in two lines); operators lead the file, title corrected to "Modal operators and frame conditions" (the file no longer defines accessibility relations).variable-lifted binders with the(R)/{R}flip.Checked, not changed:
Std.Refl R/IsTrans W Rmixed arity is mathlib's current register (IsRefldeprecated in favor ofStd.Refl, 2026-01-08).