fix(ios): correctly set foreground flag when forceShow is enabled #338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fix an issue where the
notification
event payload's propertyadditionalData.foreground
is incorrectly set when the app is in the foreground and theforceShow
option is enabled.Description
isInline
toisForeground
.isForeground
indidReceiveNotificationResponse
when the application state wasUIApplicationStateActive
. This should have been and is now set toYES
.isForeground
toNO
in thedidReceiveNotificationResponse
method when the application state isUIApplicationStateInactive
.Related Issue
n/a
How Has This Been Tested?
Built an application and tested the following:
foreShow = true
Test Case:payload.additionalData.foreground
=true
payload.additionalData.coldstart
=false
payload.additionalData.foreground
=false
payload.additionalData.coldstart
=true
payload.additionalData.foreground
=false
payload.additionalData.coldstart
=true
foreShow = false
Test Case:payload.additionalData.foreground
=true
payload.additionalData.coldstart
=false
payload.additionalData.foreground
=false
payload.additionalData.coldstart
=true
payload.additionalData.foreground
=false
payload.additionalData.coldstart
=true
Screenshots (if appropriate):
Types of changes
Checklist: