fix(ios): forceShow to display toast but trigger event until tapped #332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
I believe the purpose of implementing
forceShow
on iOS was to provide the same feature and functionality that already exists on Android. The behavior of the feature should have been identical.The goal of this PR is to correct the behavior of
forceShow
so that it aligns with Android.Original ticket and PR references: #107, #276
While the changes might seem breaking, the original intent of the implementation was not fulfilled. This update will be included in the next patch release, as the current behavior is unintended and buggy.
Description
When the app is in the foreground and
forceShow
istrue
, the notification toast should appear in the notification drawer. Theon('notification')
event should be triggered only when the user taps or clicks on the notification toast.The iOS documentation has been updated to align with Android's behavior. A comment stating that the
UNNotificationDefaultActionIdentifier
event is called when the notification is clicked has been removed as this does not follow Android's behavior.Related Issue
n/a
How Has This Been Tested?
forceShow
astrue
notification
event was triggered after thetoast
was tapped.Screenshots (if appropriate):
Types of changes
Checklist: