Add DateType
#188
Merged
Add DateType
#188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateTypeis a small project with no third-party dependencies, but it contains some huge protocols in it that can cause performance issues for type-checking. I nearly landed a change to our (WIP)Protocolimplementation in ty that would have made us never finish when type-checking this library because it would have made our performance so bad on large protocols; I only stumbled across the issue by chance because I happened to accidentally run ty on the contents of a virtual environment that hadDateTypeinstalled in it. IfDateTypehad been included as a mypy_primer project, I'd have spotted the issue much sooner!