Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added more fixes to github workflow #332

Merged
merged 1 commit into from
Oct 1, 2024
Merged

added more fixes to github workflow #332

merged 1 commit into from
Oct 1, 2024

Conversation

zackbradys
Copy link
Member

Please check below, if the PR fulfills these requirements:

  • Commit(s) and code follow the repositories guidelines.
  • Test(s) have been added or updated to support these change(s).
  • Doc(s) have been added or updated to support these change(s).

Associated Links:

  • N/A

Types of Changes:

  • Bugfix

Proposed Changes:

  • Updated timeout-minutes in the container release workflow
  • Removed continue-on-error: true in the container release workflow

Verification/Testing of Changes:

  • N/A

Additional Context:

@zackbradys zackbradys requested a review from a team October 1, 2024 13:10
@zackbradys zackbradys self-assigned this Oct 1, 2024
@zackbradys zackbradys added bug Something isn't working size/S Denotes an issue/PR requiring a relatively small amount of work labels Oct 1, 2024
@zackbradys zackbradys added this to the Hauler v1.1.0 milestone Oct 1, 2024
amartin120
amartin120 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@amartin120 amartin120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little surprised that building this container takes longer than 30 minutes. I don't mind approving the change for now though.

@zackbradys zackbradys merged commit 6373a47 into hauler-dev:main Oct 1, 2024
2 checks passed
@zackbradys zackbradys deleted the more-workflow-fixes branch October 1, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amartin120 amartin120 amartin120 approved these changes

Assignees

@zackbradys zackbradys

Labels
bug Something isn't working size/S Denotes an issue/PR requiring a relatively small amount of work
Projects
Hauler
Status: Resolved
Milestone
Hauler v1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@zackbradys @amartin120