audit feedbacks fixes #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orenyodfat
added a commit
that referenced
this pull request
May 19, 2021
* solidity 0.8.4 * Add events to HATToken. * update massUpdatePools * remove call to massUpdatePools * update * use history of totalAllocPoints * do not set on the same block twice * fix * yes. * add lastProcessedTotalAllocPoint * update tests * lint * skip gas usage in coverage * Add PoolManagerMock * naming * gas optimization * pending approvals * tests covergae * add Goverrnable.sol * test coverage * tests * tests * deployment scripts * add committee-example.json * Coverage * Coverage * spelling * pgp. fix * HAT token is capped with 1m. spelling and documentation. * function documentation.. * fix bug in rewarding committee add governance + none vesting hacker reward to the reward split * coverage * HATToken fix comment * Coverage increase (#31) * Increase coverage * More coverage * Update hattoken.js * Update hattoken.js * Update hattoken.js * use PoolManagerMock Co-authored-by: Oren Sokolowsky <oren@daostack.io> * audit feedbacks fixes (#32) * add reentrancy gurard * update pipeline * Update pipeline.yml * lint * update package-lock.json * withdraw request (#35) * withdraw request * test coverage * more coverage * solhint Co-authored-by: benk10 <ben.kaufman10@gmail.com>
shayzluf
pushed a commit
that referenced
this pull request
Jan 16, 2022
* add reentrancy gurard * update pipeline * Update pipeline.yml * lint * update package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.