refactor: remove docker-build function that produces host-arch binaries#91
Merged
refactor: remove docker-build function that produces host-arch binaries#91
Conversation
The docker-build function built binaries for the host architecture (x86_64 on most dev machines), which are useless for HALPI2 since it only runs on ARM64. Remove this function to avoid confusion. The docker-cross-build and docker-build-deb functions remain, as they correctly cross-compile to aarch64-unknown-linux-musl. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
docker-buildfunction that builds binaries for the host architecture (x86_64 on most dev machines). These binaries are useless for HALPI2 since it only runs on ARM64.What remains
docker-cross-build- Cross-compiles to ARM64 (correct)docker-build-deb- Builds ARM64 Debian packages (correct)_detect_docker_platform- Used by above functions to run Docker containers on the correct host platformContext
HALPI2 is a Raspberry Pi CM5 based device. It's impossible to run the daemon on amd64, so building host-architecture binaries is counterproductive and confusing.
🤖 Generated with Claude Code