fix(ci): add apt-distro to release.yml for stable releases#87
Merged
Conversation
The release.yml workflow was missing the apt-distro input when calling
the publish-stable shared workflow, causing stable releases to use the
default value ('trixie') instead of 'any'.
This fix ensures stable releases deploy to all distributions (bookworm,
trixie, forky), matching the behavior already set in main.yml for
pre-releases.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
mairas
added a commit
to halos-org/shared-workflows
that referenced
this pull request
Nov 22, 2025
Remove default values for apt-distro and apt-component inputs in both build-release.yml and publish-stable.yml, making them required. This prevents silent fallback to defaults which could cause packages to be deployed to incorrect distributions or components. All calling repositories have been updated to provide explicit values: - hatlabs/HALPI2-python-daemon#50 - halos-org/cockpit-apt#108 - halos-org/halos-metapackages#6 - hatlabs/HALPI2-rust-daemon#87 - halos-org/halos-marine-containers#30 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apt-distro: anyto release.yml workflowtrixieinstead ofanyRoot Cause
The
release.ymlworkflow callspublish-stable.ymlbut was not passingapt-distro. The shared workflow defaults totrixie, so stable releases were incorrectly deployed only totrixie-stableinstead of all distributions (bookworm, trixie, forky) and the legacystable/main.PR #86 fixed
main.yml(for pre-releases) but missedrelease.yml(for stable releases).Test plan
🤖 Generated with Claude Code