ETT-57 puma/rack displays "development" environment in Argo#25
Merged
ETT-57 puma/rack displays "development" environment in Argo#25
Conversation
- Invoking the app via `rackup` allows Rack's defaults to clobber the APP_ENV we are trying to set in Puma. - Puma's "user defaults" come from Rack and override the less-privileged defaults coming from ENV and elsewhere. - Bypassing `rackup` and using `puma` for the entrypoint imitates the Holdings API.
…rd library in Ruby 3.5.
mwarin
approved these changes
Jun 6, 2025
mwarin
left a comment
mwarin
left a comment
There was a problem hiding this comment.
Looks fine, just 1 question about the benchmark gem, which does not block approval. APPROVE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rackupallows Rack's defaults to clobber the APP_ENV we are trying to set in Puma.rackupand usingpumafor the entrypoint imitates the Holdings API.bundle updateto address three Rack-related dependabots.benchmarkto Gemfile since it's going to be removed from stdlib in Ruby 3.5.This can be tested locally by running e.g.
docker compose up -d weband visiting e.g.localhost:4567/v1/attributes; this branch is also running in k8s at e.g. https://rights-api-testing.macc.kubernetes.hathitrust.org/v1/attributes