Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This turned in to a bit more than routine package updates.
I upgraded svelte, the svelte prettier plugin, and storybook, among other things. One of the three of these packages set off a wave of new compiler warnings, both for svelte and storybook. I refactored a few things to silence the warnings that litter the console during the build.
All of the warning were about the same type of problem: referencing state locally. These components weren't broken, but the way the variables were being referenced meant that the values weren't being updated reactively. Probably most of them didn't really need to be reactive state variables seeing as how we never had an issue with them not correctly updating, but I refactored them so they are properly reactive now.
The PingCallbackDecorator component for storybook had a bunch of those warnings, but I don't care if those values are reactive in the story/tests, since I'm mocking the data/functions. I left those as-is, but wrapped them in an
untrack()function to tell the svelte compiler that I know they are not reactive and please don't warn me about them.All storybook tests are passing and no visual changes have been detected. This is staged on dev-3 (for everything except page turner) if you want to take a look!