Conversation
Member
Author
|
This produces valid images; still to-do is to pick a PSNR that seems reasonable for our images (requires testing on sample images) |
respinos
reviewed
Apr 12, 2022
respinos
reviewed
Apr 12, 2022
aelkiss
commented
Apr 13, 2022
Member
Author
Done, using requested PSNR 32. This results in similar average PSNR on a variety of scanned book images to kakadu 6.4.0 as evaluated by imagemagick with |
* Uses grok for compressing incoming contone TIFFs to JPEG2000 and for recompressing lossless JPEG2000 images, using parameters that produce similar quality output to Kakadu across a sample of digitized book images * Remove unused kdu_munge code (see comments) * Update tool versions for PREMIS (should really get these via dpkg) * Test that XMP is preserved when remediating images
Member
Author
|
This adds a couple of tests around preserving XMP. @respinos I think this should be good to go after tests are passing, but let me know if anything else comes to mind regarding using grok to create jpeg2000. |
niquerio
added a commit
to mlibrary/divp
that referenced
this pull request
Jan 15, 2026
relevant HT PR: hathitrust/feed#95 grok is available in the mlibrary apt repo
niquerio
added a commit
to mlibrary/divp
that referenced
this pull request
Jan 15, 2026
relevant HT PR: hathitrust/feed#95 grok is available in the mlibrary apt repo
niquerio
added a commit
to mlibrary/divp
that referenced
this pull request
Jan 15, 2026
relevant HT PRs: * hathitrust/feed#95 * hathitrust/feed#172 grokj2k is available in the mlibrary apt repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kdu_mungecode (see comments)