Merged
Conversation
Contributor
Author
|
@aelkiss I would like a chance to run this through with you once or twice. I think there are dueling red herrings:
|
aelkiss
approved these changes
Jun 10, 2025
Member
aelkiss
left a comment
There was a problem hiding this comment.
After testing with the correct IA ID matching this arkid, everything looks good. We added ETT-340 as a potential future step to make testing this kind of thing easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for https://hathitrust.atlassian.net/browse/GS-13230
... in which some of
bc's IA items were failing because they fall back on an invalid resolution value from the$volume.Single line fix that removes
ppifrom resolution values.This should fail on the main branch:
... but should succeed on this PR branch: