Use EP0 buffer directly if it's large enough #3352
Open
+63
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes control transfer buffer management in TinyUSB by allowing device classes to use the EP0 buffer directly when it's large enough, avoiding unnecessary dedicated buffer allocations and memory copies. This improves memory efficiency on resource-constrained devices while maintaining the same functional behavior.
Key Changes
- Added
usbd_control_get_buffer()API to expose the EP0 buffer to device class implementations - Optimized control transfer path to skip unnecessary memory copies when the buffer is already the EP0 buffer
- Updated Audio and DFU device classes to conditionally use EP0 buffer instead of always allocating dedicated buffers
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/device/usbd_control.c | Added function to expose EP0 buffer and optimized copy operations to skip when buffer pointer matches EP0 buffer |
| src/device/usbd.h | Added declaration for usbd_control_get_buffer() function |
| src/class/dfu/dfu_device.c | Conditionally allocates transfer buffer only when larger than EP0, otherwise uses EP0 buffer directly via helper function |
| src/class/audio/audio_device.c | Conditionally allocates control buffer only when larger than EP0, uses EP0 buffer otherwise, and removes length cropping code that relied on dedicated buffer always existing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Signed-off-by: HiFiPhile <admin@hifiphile.com>
Signed-off-by: HiFiPhile <admin@hifiphile.com>
Signed-off-by: HiFiPhile <admin@hifiphile.com>
Signed-off-by: HiFiPhile <admin@hifiphile.com>
HiFiPhile
force-pushed
the
ep0_direct
branch
from
73a101e to
23451ce
Compare
Size Difference ReportBecause TinyUSB code size varies by port and configuration, the metrics below represent the averaged totals across all example builds. Note: If there is no change, only one value is shown. Changes >1% in size
Changes <1% in size
No changes
|
Signed-off-by: HiFiPhile <admin@hifiphile.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves how control transfer buffers are managed for both the Audio and DFU device classes. The main enhancement is to allow the use of the endpoint 0 buffer for control transfers when it is large enough, falling back to a dedicated buffer only when necessary.