Enhance fsdev #2739
Merged
Enhance fsdev #2739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1199,7 +1201,8 @@ | |||
| break; | |||
|
|
|||
| case DCD_EVENT_SETUP_RECEIVED: | |||
| _usbd_dev.setup_count++; | |||
| // TU_ASSERT(event->setup_received.bRequest != 0,); | |||
Check notice
Code scanning / CodeQL
Commented-out code Note
There was a problem hiding this comment.
this comment for catching ch32v203 issue with windows with -O0/-Og
|
as follow-up #2755 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Trying to fix race condition with ch32v203 with windows, still haven't fixed it yet. But fixed a few issue while testing. Also try to improve fsdev driver.
Major rework to fsdev, simplify pma access and ep register manipulation and write (only write 1 as needed).
Note: race condition with windows on -O0/-Og still occur, issue is the setup packet received by v203 is incorrect data, although rx_count = 8 and setup bit is set.