Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCM: avoid recursions in tud_network_recv_renew() #2713

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

rgrr
Copy link
Contributor

@rgrr rgrr commented Jul 15, 2024

Describe the PR
Due to some expectations in the glue code, a recursive call of tud_network_recv_renew() might happen.
This is the corresponding fix for it.

Additional context
See discussions in #2711

Closes #2711

@HiFiPhile
Copy link
Collaborator

Thank you @rgrr, tested ok on my side.

Hi @showier-drastic, did you have time to check it ?

@showier-drastic
Copy link

Sorry for the delayed response, this works for me.

Copy link
Collaborator

@HiFiPhile HiFiPhile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rgrr, tested working on STM32F723E-DISCO.

@HiFiPhile HiFiPhile merged commit 038be21 into hathach:master Nov 1, 2024
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack overflow with the new NCM driver
3 participants