dwc2: add endpoint allocation support. #2333
Conversation
| @@ -650,6 +658,108 @@ void dcd_edpt_close_all(uint8_t rhport) { | |||
| _allocated_fifo_words_tx = 16; | |||
| } | |||
|
|
|||
| bool dcd_edpt_iso_alloc(uint8_t rhport, uint8_t ep_addr, uint16_t largest_packet_size) | |||
There was a problem hiding this comment.
we should refactor this to share code with dcd_edpt_open(), since it is quite a duplication. I can do it if you don't mind testing again :)
There was a problem hiding this comment.
Yes please do it.
|
For tinyusb/src/portable/synopsys/dwc2/dcd_dwc2.c Line 632 in f1898fe |
|
Refactor done, maybe you want to apply the new coding style. |
|
@kkitayam When you have time could you add ISO endpoint allocation support to UVC class ? The idea is to avoid USB buffer alloc/free at runtime as it's hard to manage buffer on some devices. It's pretty simple:
Currently the main problem is in dwc2 driver, something is wrong with runtime buffer size adjustment, after ISO endpoint closing there is a chance that the device stop transferring packets. Packets have been acked but no interrupt fired:
|
|
@hathach Could you take a look of my pending PRs when you have some time ? Especially this one is necessary to make audio class running reliably. |
sorry, will review this asap. |
Describe the PR
Add endpoint buffer allocation support, to avoid USB buffer alloc/free at runtime.
Currently something is wrong with runtime buffer size adjustment, after some endpoint close/open cycle there is a chance that the device stop transferring/receiving packets.
Also flush FIFO on bus reset, as incomplete iso transfers can cause some strange issues, seems flushing FIFO is a work around.