-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
esp: Fix Isochronous transfers #1690
Merged
hathach
merged 1 commit into
hathach:master
from
tore-espressif:fix/espressif/iso_transfers
Oct 21, 2022
Merged
esp: Fix Isochronous transfers #1690
hathach
merged 1 commit into
hathach:master
from
tore-espressif:fix/espressif/iso_transfers
Oct 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On ESP32-S2/S3 ISO transfers must be configured for even or odd frame. Closes hathach#1382
PanRe
approved these changes
Oct 18, 2022
cc @me-no-dev |
@hathach I would vote to merge the PR, you are good with that? |
Closed
hathach
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PanRe It works fine when using dwc2 driver for esp32s2/s3, no packet missed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On ESP32-S2/S3 ISO IN packets must be configured for even or odd frame. If they're not, they are transmitted only in even frames, so every second packet is lost.
Closes #1382
Describe the PR
Fix Isochronous IN transfers on Espressif's SoCs.
cc @kaspernyhus @leeebo