Add support for MJPEG on UVC #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you see if this PR is useful or not for your application which indicated #1118 (comment) ? |
tswan-quasi
suggested changes
Oct 11, 2022
There was a problem hiding this comment.
I only checked the descriptors and class files as that is what I used in my setup. Some type consistency changes that also affect the functionality. Regardless, it runs fine on my setup, tested on LPC55S69 (using #1676).
|
@tswan-quasi |
hathach
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
superb! Thank you very much for yet another great PR. And thank @tswan-quasi for helping with reviewing. To be honest, I am still not catching up with UVC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Add support for MJPEG on UVC.
It is tested with
video_captureexample onfrdm_kl25zandraspberry pi picoAdditional context
video_captureuses MJPG video instead of uncompressed video when it builds withCFG_EXAMPLE_VIDEO_READONLYdefined.If a MCU has not enough SRAM for frame buffers,
CFG_EXAMPLE_VIDEO_READONLYis already defined inboard.mkathw/bsp/<board>. For example,frdm_kl25zand so on. Any other MCU which has enough SRAM for frame buffers use uncompressed video in default. To force the use of MJPG video, add theFORCE_READONLYargument to make or cmake.For example: