Set the standard inquiry response additional length field. #1349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
The standard inquiry response additional length field needs to be set to the length in bytes of the remaining standard inquiry data (i.e. N - 5), otherwise the kernel driver issues a warning about short inquiry response.
Additional context
On Linux I see the following warning, it seems the driver assumes the response is the minimum 36 bytes:
This warning is gone after setting the additional length field.
See section 3.6.2 Standard INQUIRY data in Seagate SCSI reference manual (PDF link).
Tested using
sg_inq
, without this patch (note the length=5):With this patch (the expected 36 bytes length):