Changed url in config.yaml #772
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve issue hasura#751
|
|
|
@vinayak42 Thanks for the contribution. 🙏 But this change does not fix #751. It is more involved and require Go code changes. I will be commenting on the issue with more details. Feel free to open another PR. 😄 |
|
Review app https://hge-ci-pull-772.herokuapp.com is deleted |
hasura-bot
pushed a commit
that referenced
this pull request
Jun 27, 2024
### What This adds a flag, `--partial-supergraph`, which instructs the metadata resolver to prune relationships to unknown subgraphs rather than failing to resolve. ### How The flag gets passed through as `metadata_resolve::configuration::Configuration`, and known subgraphs are now tracked in `MetadataAccessor`. If the flag is set and a relationship target refers to an unknown subgraph, we return an empty list of relationships instead of failing. Some test infrastructure has been added to set configuration flags per test. V3_GIT_ORIGIN_REV_ID: 6f0de2442a3bfc7c7a4c48e3dc7296dc1538cd67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issue #751
I changed the existing url as required.
Fix #751
As this is my first PR to Hasura graph-ql engine, please mention further changes.
Description
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
Solution and Design
Type
Checklist: