Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a footer to chat app with a hasura logo #752

Merged
merged 5 commits into from
Oct 15, 2018
Merged

add a footer to chat app with a hasura logo #752

merged 5 commits into from
Oct 15, 2018

Conversation

wawhal
Copy link
Contributor

@wawhal wawhal commented Oct 15, 2018

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@CLAassistant
Copy link

CLAassistant commented Oct 15, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@wawhal wawhal added s/ok-to-merge Status: This pull request can be merged to master c/community Related to community content labels Oct 15, 2018
@shahidhk shahidhk changed the title add a footer to chat app with a Hasura logo add a footer to chat app with a hasura logo Oct 15, 2018
@shahidhk shahidhk merged commit fb9407f into hasura:master Oct 15, 2018
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-752.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Jun 24, 2024
@SamirTalwar @hasura-bot
Remove redundant clones. (#752)
1378730 
I noticed a few extra calls to `.clone()` while working on an unrelated
refactor. I want to remove them for brevity and simplicity; I don't
expect a performance improvement.

This turns on the Clippy warning `redundant_clone`, which detects
unnecessary calls to `.clone()` (and `.to_string()`).

It is an unstable warning and so might reports some false positives. If
we find any, we can suppress the warning there.

V3_GIT_ORIGIN_REV_ID: a713f29cf862d6f4cb40300105c6b9f96df00676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahidhk shahidhk shahidhk approved these changes

Assignees
No one assigned
Labels
c/community Related to community content s/ok-to-merge Status: This pull request can be merged to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wawhal @CLAassistant @hasura-bot @shahidhk