Fix: GraphiQL clears request after page refresh (close #6521) #6533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
iykekings seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Deploy preview for hasura-docs ready! Built with commit 2666ac8 |
beerose
suggested changes
Feb 8, 2021
Comment on lines
+124
to
+126
| tables: flatten( | ||
| state.metadata.metadataObject?.sources.map(s => s.tables) | ||
| ), |
There was a problem hiding this comment.
Use selector from src/metadata/selector.ts. Create one if there isn't any.
| @@ -5,6 +5,7 @@ import Helmet from 'react-helmet'; | |||
| import ApiRequestWrapper from './ApiRequestWrapper'; | |||
|
|
|||
| import globals from '../../../Globals'; | |||
| import { flatten } from 'lodash'; | |||
There was a problem hiding this comment.
Let's not introduce lodash just for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue with graphlQl queries not persisting after refresh. (close #6521)
Description
This fix ensures that the queries are persisted in LocalStorage and also displayed on refresh/reload.
Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR. If no changelog is required, then add theno-changelog-requiredlabel.Affected components
Related Issues
#6521
Steps to test and verify
Limitations, known bugs & workarounds
I'm not sure this is a limitation, but this PR used
flattenfromlodash. Array.prototype.flatMap might have been better but out typescript lib typedefs doesn't include it yet.Does this PR add a new Metadata feature?
GraphQL
Breaking changes