Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Remove metadata.yaml file from update-config-v2 in migrations folder (#fixes 6112) #6121

Closed
wants to merge 10 commits into from
Closed

CLI: Remove metadata.yaml file from update-config-v2 in migrations folder (#fixes 6112) #6121

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c93a7e3
to remove metadata file in migrations directory
purush7 Nov 2, 2020
0a49886
modified the code to check existence of file before removing
purush7 Nov 3, 2020
1a53924
Merge branch 'master' into remove_metadata_file
purush7 Nov 3, 2020
06c350e
changed the error message of metadata directory creation
purush7 Nov 6, 2020
abf601d
changed from returning error to warning log for removing metadata file
purush7 Dec 14, 2020
7d1027c
update with logger.Warnln
purush7 Dec 14, 2020
304af95
Merge branch 'master' into remove_metadata_file
purush7 Dec 15, 2020
62cd144
Update scripts_update_config_v2.go
purush7 Dec 15, 2020
28cb338
Merge branch 'master' into remove_metadata_file
purush7 Jan 4, 2021
18d4ed2
Merge branch 'master' into remove_metadata_file
purush7 Feb 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update scripts_update_config_v2.go
  • Loading branch information
@purush7
purush7 authored Dec 15, 2020
commit 62cd1449d64117e4007be823c1eac4b35b5fe95d
4 changes: 2 additions & 2 deletions cli/commands/scripts_update_config_v2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,10 +344,10 @@ func newScriptsUpdateConfigV2Cmd(ec *cli.ExecutionContext) *cobra.Command {
ec.Spinner.Stop()
ec.Logger.Infoln("Updated config to version 2")

if _, err = os.Stat(filepath.Join(ec.MigrationDir, "metadata.yaml")); err == nil || os.IsExist(err) {
if f, _ := os.Stat(filepath.Join(ec.MigrationDir, "metadata.yaml")); f != nil {
err = os.Remove(filepath.Join(ec.MigrationDir, "metadata.yaml"))
if err != nil {
ec.Logger.Warnln("Warning: cannot remove metadata.yaml file")
ec.Logger.Warnln("Warning: cannot remove metadata.yaml file ",err)
}
}

Expand Down