Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: Pass EKG Metrics Store as argument to runHGEServer #5560

Merged
merged 5 commits into from
Aug 18, 2020
Merged

server: Pass EKG Metrics Store as argument to runHGEServer #5560

merged 5 commits into from
Aug 18, 2020

Conversation

Naveenaidu
Copy link
Contributor

@Naveenaidu Naveenaidu commented Aug 10, 2020 •
edited
Loading

Description

We need to make sure OSS can surface metrics in Datadog via Pro, so that means sending the metrics store value into OSS during the call to mkWaiApp/runHGEServer.

Affected components

  • Server

Solution and Design

We could make the store in the Main.hs and pass it as an argument to runHGEServer

@Naveenaidu Naveenaidu self-assigned this Aug 10, 2020
@hasura-bot
Copy link
Contributor

Review app for commit 438fa6a deployed to Heroku: https://hge-ci-pull-5560.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5560-438fa6a4

@Naveenaidu Naveenaidu requested a review from paf31 August 10, 2020 16:19
paf31
paf31 reviewed Aug 10, 2020
View reviewed changes
server/src-lib/Hasura/App.hs Outdated Show resolved Hide resolved
@Naveenaidu Naveenaidu changed the title 453 share ekg metrics Share EKG Metrics Store between OSS and PRO Aug 11, 2020
@Naveenaidu Naveenaidu force-pushed the 453-share-EKG-metrics branch from 438fa6a to 8f296f8 Compare August 11, 2020 11:02
@Naveenaidu Naveenaidu requested a review from paf31 August 11, 2020 11:02
@Naveenaidu Naveenaidu marked this pull request as ready for review August 11, 2020 11:30
@Naveenaidu
Move creation of EKG Store to Main.hs
3e2af4f 
This helps to share metrics between pro and OSS and
helps surface the metrics from OSS in Datadog via
Pro.
@Naveenaidu Naveenaidu force-pushed the 453-share-EKG-metrics branch from 8f296f8 to 3e2af4f Compare August 11, 2020 11:36
@hasura-bot
Copy link
Contributor

Review app for commit 3e2af4f deployed to Heroku: https://hge-ci-pull-5560.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5560-3e2af4fb

@paf31 paf31 changed the title Share EKG Metrics Store between OSS and PRO server: Pass EKG Metrics Store as argument to runHGEServer Aug 11, 2020
@paf31 paf31 requested a review from 0x777 August 11, 2020 19:35
@hasura-bot
Copy link
Contributor

Review app for commit 8a96420 deployed to Heroku: https://hge-ci-pull-5560.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5560-8a964203

@paf31
Copy link
Contributor

paf31 commented Aug 18, 2020

@0x777 Can you please review this one, or assign it to someone to review? Thanks!

@hasura-bot
Copy link
Contributor

Review app for commit b82190d deployed to Heroku: https://hge-ci-pull-5560.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5560-b82190de

evertedsphere
evertedsphere approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@evertedsphere evertedsphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ecthiender
ecthiender approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@ecthiender ecthiender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasura-bot
Copy link
Contributor

Review app for commit 8f23812 deployed to Heroku: https://hge-ci-pull-5560.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5560-8f23812d

@paf31 paf31 merged commit b14a4f2 into hasura:master Aug 18, 2020
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-5560.herokuapp.com is deleted

stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@Naveenaidu @paf31 @stevefan1999-personal
server: Pass EKG Metrics Store as argument to runHGEServer (hasura#5560)
f34addc 
* Add ekg-core to build-executable .cabal

* Move creation of EKG Store to Main.hs

This helps to share metrics between pro and OSS and
helps surface the metrics from OSS in Datadog via
Pro.

Co-authored-by: Phil Freeman <phil@hasura.io>
@Naveenaidu Naveenaidu deleted the 453-share-EKG-metrics branch April 28, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evertedsphere evertedsphere evertedsphere approved these changes

@0x777 0x777 0x777 approved these changes

@paf31 paf31 paf31 approved these changes

@ecthiender ecthiender ecthiender approved these changes

Assignees

@Naveenaidu Naveenaidu

Labels
no-changelog-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Naveenaidu @hasura-bot @paf31 @ecthiender @0x777 @evertedsphere