console: don't generate unnecessary migrations (close #4215)

CHANGELOG.md

@@ -24,6 +24,7 @@ The order and collapsed state of columns is now persisted across page navigation
 - console: decouple data rows and count fetch in data browser to account for really large tables (close #3793) (#4269)
 - console: update cookie policy for API calls to "same-origin"
 - console: redirect to /:table/browse from /:table (close #4330) (#4374)
+- console: fix generating unnecessary migrations after modifying table columns (close #4125) (#4393)
 - docs: add One-Click Render deployment guide (close #3683) (#4209)
 - server: reserved keywords in column references break parser (fix #3597) #3927
 - server: fix postgres specific error message that exposed database type on invalid query parameters (#4294)

console/src/components/Services/Data/TableModify/ModifyActions.js

@@ -84,8 +84,8 @@ const REMOVE_PRIMARY_KEY = 'ModifyTable/REMOVE_PRIMARY_KEY';
 const RESET_PRIMARY_KEY = 'ModifyTable/RESET_PRIMARY_KEY';
 const SET_PRIMARY_KEYS = 'ModifyTable/SET_PRIMARY_KEYS';
 
-const SET_COLUMN_EDIT = 'ModifyTable/SET_COLUMN_EDIT;';
-const RESET_COLUMN_EDIT = 'ModifyTable/RESET_COLUMN_EDIT;';
+const SET_COLUMN_EDIT = 'ModifyTable/SET_COLUMN_EDIT';
+const RESET_COLUMN_EDIT = 'ModifyTable/RESET_COLUMN_EDIT';
 const EDIT_COLUMN = 'ModifyTable/EDIT_COLUMN';
 
 const SET_FOREIGN_KEYS = 'ModifyTable/SET_FOREIGN_KEYS';
@@ -1438,18 +1438,25 @@ const saveTableCommentSql = isTable => {
 };
 
 const isColumnUnique = (tableSchema, colName) => {
-  return (
-    tableSchema.unique_constraints.filter(
+  const { primary_key, unique_constraints } = tableSchema;
+
+  const columnPkConstraint =
+    primary_key.columns.includes(colName) && primary_key.columns.length === 1;
+
+  const columnUniqueConstraint =
+    unique_constraints.filter(
       constraint =>
         constraint.columns.includes(colName) && constraint.columns.length === 1
-    ).length !== 0
-  );
+    ).length > 0;
+
+  return columnPkConstraint || columnUniqueConstraint;
 };
 
 const saveColumnChangesSql = (colName, column, onSuccess) => {
   // eslint-disable-line no-unused-vars
   return (dispatch, getState) => {
     const columnEdit = getState().tables.modify.columnEdit[colName];
+
     const { tableName } = columnEdit;
     const colType = columnEdit.type;
     const nullable = columnEdit.isNullable;
@@ -1464,7 +1471,7 @@ const saveColumnChangesSql = (colName, column, onSuccess) => {
     const table = findTable(getState().tables.allSchemas, tableDef);
 
     // check if column type has changed before making it part of the migration
-    const originalColType = column.data_type; // "value"
+    const originalColType = column.udt_name; // "value"
     const originalColDefault = column.column_default || ''; // null or "value"
     const originalColComment = column.comment || ''; // null or "value"
     const originalColNullable = column.is_nullable; // "YES" or "NO"