fix console server-build script #2790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `rm static/dist/versioned/*.gz` step would fail on the first run, since the glob would match no files, and `rm` would complain. This approach just deletes the whole directory, which is probably better, anyway, since it avoids any lingering outdated files.
|
Deploy preview for hasura-docs ready! Built with commit c06ae4a |
|
Oh, cool. Do you want to incorporate that into this repository yourself, then? |
|
Review app for commit dd8c403 deployed to Heroku: https://hge-ci-pull-2790.herokuapp.com |
rikinsk
previously approved these changes
Sep 24, 2019
|
I am adding a better version of this script in a while. |
shahidhk
changed the title
shahidhk
approved these changes
Sep 24, 2019
rikinsk
approved these changes
Sep 24, 2019
|
Review app https://hge-ci-pull-2790.herokuapp.com is deleted |
rikinsk
added a commit
to rikinsk/graphql-engine
that referenced
this pull request
Sep 26, 2019
This reverts commit eb0c1f6.
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a tiny quick fix for the
npm run server-buildscript: previously, therm static/dist/versioned/*.gzstep would fail on first run, since the glob would match no files, andrmwould complain. This approach just deletes the whole directory, which is probably better, anyway, since it avoids leaving behind any lingering stale files.Affected components