Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firebase2graphql (v0.0.2): support array types in firebase json (close #1829) #1900

Merged
merged 8 commits into from
Apr 3, 2019
Merged

firebase2graphql (v0.0.2): support array types in firebase json (close #1829) #1900

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7dd2a30
add support for arrays in firebase json
wawhal Mar 28, 2019
9c3abcf
lint
wawhal Mar 28, 2019
3956e7d
improve error message and use json type if the type os object or array
wawhal Mar 28, 2019
8aa9f48
version bump
wawhal Apr 1, 2019
1bef44a
Merge branch 'master' of github.com:hasura/graphql-engine into issue-…
wawhal Apr 1, 2019
55b33e1
fix typo
wawhal Apr 1, 2019
5363e99
changed syntax for checking variable type
wawhal Apr 3, 2019
fad5db8
Merge branch 'master' of github.com:hasura/graphql-engine into issue-…
wawhal Apr 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve error message and use json type if the type os object or array
  • Loading branch information
@wawhal
wawhal committed Mar 28, 2019
commit 3956e7dc1b60d8f168fd4251f3074a8e678eac80
4 changes: 2 additions & 2 deletions community/tools/firebase2graphql/src/import/generateTables.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ const getDataType = (data, column) => {
if (data.constructor.name === 'Date') {
return 'timestamptz';
}
if (data.constructor.name === 'Object') {
if (data.constructor.name === 'Object' || data.constructor.name === 'Array') {
return 'json';
}
throwError(`Message: invalid data type given for column ${column}: ${typeof data}`);
throwError(`Message: invalid data type given for column ${column}: ${data.constructor.name}`);
};

const isForeign = (name, db) => {
Expand Down